🐛 [REST API] Restore possibility to update a service configuration property with a "default" value #4120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to allow update to default values for properties
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4120 +/- ##
=============================================
- Coverage 16.81% 16.81% -0.01%
Complexity 22 22
=============================================
Files 2019 2019
Lines 52437 52437
Branches 4423 4423
=============================================
- Hits 8816 8815 -1
Misses 43224 43224
- Partials 397 398 +1
|
Coduz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With previous PRs I modified the logic of service configuration unmarshalling, reporting to clients the missing "type" values inside invalid PUT request. Doing so, I did not consider the case where a client would like to update a property with a "default" value
for example, an unlimited "password.minLength", with this block:
{
"name": "password.minLength",
"array": false,
"encrypted": false
}
Here I refined the unmarshalling check logic to restore this possibility